memory: pl172: simplify with dev_err_probe()

Use dev_err_probe() to avoid dmesg flood on actual defer.  This makes
the code also simpler.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huwei.com>
Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
Link: https://lore.kernel.org/r/20240823-b4-cleanup-h-guard-v1-4-01668915bd55@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

diff --git a/drivers/memory/pl172.c b/drivers/memory/pl172.c
index 9eb8cc7de494a8d6d558e17f3ae519635abdf7bc..390012401f642f639ae026db453032db8432c09d 100644 (file)
--- a/drivers/memory/pl172.c
+++ b/drivers/memory/pl172.c
@@ -217,10 +217,9 @@ static int pl172_probe(struct amba_device *adev, const struct amba_id *id)
                return -ENOMEM;
 
        pl172->clk = devm_clk_get(dev, "mpmcclk");
-       if (IS_ERR(pl172->clk)) {
-               dev_err(dev, "no mpmcclk provided clock\n");
-               return PTR_ERR(pl172->clk);
-       }
+       if (IS_ERR(pl172->clk))
+               return dev_err_probe(dev, PTR_ERR(pl172->clk),
+                                    "no mpmcclk provided clock\n");
 
        ret = clk_prepare_enable(pl172->clk);
        if (ret) {