]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Mon, 11 Mar 2019 10:27:12 +0000 (11:27 +0100)
committerLaurent Vivier <laurent@vivier.eu>
Thu, 2 May 2019 16:12:58 +0000 (18:12 +0200)
Avoid to clutter stdout until explicitly requested
(with -d guest_errors):

  $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta
  Bad SWSTYLE=0x04

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20190311102712.8572-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/net/pcnet.c

index d9ba04bdfc62800b3f6f0d196aade4ad41554d66..16683091c9398b60ab13d1c4868c2d4e32f09dc0 100644 (file)
@@ -36,6 +36,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu/log.h"
 #include "hw/qdev.h"
 #include "net/net.h"
 #include "net/eth.h"
@@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val)
             val |= 0x0300;
             break;
         default:
-            printf("Bad SWSTYLE=0x%02x\n", val & 0xff);
+            qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n",
+                          val & 0xff);
             val = 0x0200;
             break;
         }