]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: stmmac: rk: use device rather than platform device in rk_priv_data
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Mon, 16 Jun 2025 10:15:56 +0000 (11:15 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 17 Jun 2025 22:30:14 +0000 (15:30 -0700)
All the code in dwmac-rk uses &bsp_priv->pdev->dev, nothing uses
bsp_priv->pdev directly. Store the struct device rather than the
struct platform_device in struct rk_priv_data, and simplifying the
code.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/E1uR6se-004Ktz-Dx@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c

index 5865a17d5fe8abfc3391ebcca9eb15de42a5b804..7ee101a6cfcf78a9d519ebbe3909a864a324880e 100644 (file)
@@ -67,7 +67,7 @@ enum rk_clocks_index {
 };
 
 struct rk_priv_data {
-       struct platform_device *pdev;
+       struct device *dev;
        phy_interface_t phy_iface;
        int id;
        struct regulator *regulator;
@@ -248,7 +248,7 @@ static int px30_set_speed(struct rk_priv_data *bsp_priv,
                          phy_interface_t interface, int speed)
 {
        struct clk *clk_mac_speed = bsp_priv->clks[RK_CLK_MAC_SPEED].clk;
-       struct device *dev = &bsp_priv->pdev->dev;
+       struct device *dev = bsp_priv->dev;
        unsigned int con1;
        long rate;
 
@@ -1380,8 +1380,8 @@ static const struct rk_gmac_ops rv1126_ops = {
 static int rk_gmac_clk_init(struct plat_stmmacenet_data *plat)
 {
        struct rk_priv_data *bsp_priv = plat->bsp_priv;
-       struct device *dev = &bsp_priv->pdev->dev;
        int phy_iface = bsp_priv->phy_iface;
+       struct device *dev = bsp_priv->dev;
        int i, j, ret;
 
        bsp_priv->clk_enabled = false;
@@ -1473,8 +1473,8 @@ static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable)
 static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
 {
        struct regulator *ldo = bsp_priv->regulator;
+       struct device *dev = bsp_priv->dev;
        int ret;
-       struct device *dev = &bsp_priv->pdev->dev;
 
        if (enable) {
                ret = regulator_enable(ldo);
@@ -1598,7 +1598,7 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev,
        dev_info(dev, "integrated PHY? (%s).\n",
                 bsp_priv->integrated_phy ? "yes" : "no");
 
-       bsp_priv->pdev = pdev;
+       bsp_priv->dev = dev;
 
        return bsp_priv;
 }
@@ -1618,7 +1618,7 @@ static int rk_gmac_check_ops(struct rk_priv_data *bsp_priv)
                        return -EINVAL;
                break;
        default:
-               dev_err(&bsp_priv->pdev->dev,
+               dev_err(bsp_priv->dev,
                        "unsupported interface %d", bsp_priv->phy_iface);
        }
        return 0;
@@ -1626,8 +1626,8 @@ static int rk_gmac_check_ops(struct rk_priv_data *bsp_priv)
 
 static int rk_gmac_powerup(struct rk_priv_data *bsp_priv)
 {
+       struct device *dev = bsp_priv->dev;
        int ret;
-       struct device *dev = &bsp_priv->pdev->dev;
 
        ret = rk_gmac_check_ops(bsp_priv);
        if (ret)
@@ -1683,7 +1683,7 @@ static void rk_gmac_powerdown(struct rk_priv_data *gmac)
        if (gmac->integrated_phy && gmac->ops->integrated_phy_powerdown)
                gmac->ops->integrated_phy_powerdown(gmac);
 
-       pm_runtime_put_sync(&gmac->pdev->dev);
+       pm_runtime_put_sync(gmac->dev);
 
        phy_power_on(gmac, false);
        gmac_clk_enable(gmac, false);