]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i2c: i801: Fix the Intel Diamond Rapids features
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Tue, 28 Oct 2025 10:53:42 +0000 (11:53 +0100)
committerAndi Shyti <andi.shyti@kernel.org>
Tue, 28 Oct 2025 18:02:47 +0000 (19:02 +0100)
Diamond Rapids does not support the iTCO feature.
Adding also the missing comment describing Diamond
Rapids while at it.

Fixes: 084cbc58e720 ("i2c: i801: Add support for Intel Diamond Rapids")
Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20251028105342.2281687-1-heikki.krogerus@linux.intel.com
drivers/i2c/busses/i2c-i801.c

index 91d4d14605aaadf0cc4673be2fb0aacc0b601145..81e6e2d7ad3dcc660f434c9ccca9c58c595b327e 100644 (file)
@@ -84,6 +84,7 @@
  * Panther Lake-H (SOC)                0xe322  32      hard    yes     yes     yes
  * Panther Lake-P (SOC)                0xe422  32      hard    yes     yes     yes
  * Wildcat Lake-U (SOC)                0x4d22  32      hard    yes     yes     yes
+ * Diamond Rapids (SOC)                0x5827  32      hard    yes     yes     yes
  *
  * Features supported by this driver:
  * Software PEC                                no
@@ -1055,7 +1056,7 @@ static const struct pci_device_id i801_ids[] = {
        { PCI_DEVICE_DATA(INTEL, METEOR_LAKE_SOC_S_SMBUS,       FEATURES_ICH5 | FEATURE_TCO_CNL) },
        { PCI_DEVICE_DATA(INTEL, METEOR_LAKE_PCH_S_SMBUS,       FEATURES_ICH5 | FEATURE_TCO_CNL) },
        { PCI_DEVICE_DATA(INTEL, BIRCH_STREAM_SMBUS,            FEATURES_ICH5)                   },
-       { PCI_DEVICE_DATA(INTEL, DIAMOND_RAPIDS_SMBUS,          FEATURES_ICH5 | FEATURE_TCO_CNL) },
+       { PCI_DEVICE_DATA(INTEL, DIAMOND_RAPIDS_SMBUS,          FEATURES_ICH5)                   },
        { PCI_DEVICE_DATA(INTEL, ARROW_LAKE_H_SMBUS,            FEATURES_ICH5 | FEATURE_TCO_CNL) },
        { PCI_DEVICE_DATA(INTEL, PANTHER_LAKE_H_SMBUS,          FEATURES_ICH5 | FEATURE_TCO_CNL) },
        { PCI_DEVICE_DATA(INTEL, PANTHER_LAKE_P_SMBUS,          FEATURES_ICH5 | FEATURE_TCO_CNL) },