]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ARM: shmobile: r8a7779: hide unused r8a7779_platform_cpu_kill
authorArnd Bergmann <arnd@arndb.de>
Fri, 6 Jul 2018 15:15:19 +0000 (17:15 +0200)
committerSimon Horman <horms+renesas@verge.net.au>
Fri, 20 Jul 2018 11:44:09 +0000 (13:44 +0200)
After the cleanup in r8a7779_smp_prepare_cpus(), the only remaining caller of
r8a7779_platform_cpu_kill() is in an ifdef, which leads to a build warning
without CONFIG_HOTPLUG_CPU:

arch/arm/mach-shmobile/smp-r8a7779.c:26:12: error: 'r8a7779_platform_cpu_kill' defined but not used [-Werror=unused-function]

This moves the function inside of that #ifdef to avoid the warning.

Fixes: 62f55ce683e3 ("ARM: shmobile: r8a7779: Stop powering down secondary CPUs during early boot")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
arch/arm/mach-shmobile/smp-r8a7779.c

index b7fe1f489b085f58fc7188a93566fd911a7aaae0..0ed73b650c141e589118157777190f42c69570f9 100644 (file)
 #define AVECR IOMEM(0xfe700040)
 #define R8A7779_SCU_BASE 0xf0000000
 
-static int r8a7779_platform_cpu_kill(unsigned int cpu)
-{
-       int ret = -EIO;
-
-       cpu = cpu_logical_map(cpu);
-       if (cpu)
-               ret = rcar_sysc_power_down_cpu(cpu);
-
-       return ret ? ret : 1;
-}
-
 static int r8a7779_boot_secondary(unsigned int cpu, struct task_struct *idle)
 {
        int ret = -EIO;
@@ -55,6 +44,17 @@ static void __init r8a7779_smp_prepare_cpus(unsigned int max_cpus)
 }
 
 #ifdef CONFIG_HOTPLUG_CPU
+static int r8a7779_platform_cpu_kill(unsigned int cpu)
+{
+       int ret = -EIO;
+
+       cpu = cpu_logical_map(cpu);
+       if (cpu)
+               ret = rcar_sysc_power_down_cpu(cpu);
+
+       return ret ? ret : 1;
+}
+
 static int r8a7779_cpu_kill(unsigned int cpu)
 {
        if (shmobile_smp_scu_cpu_kill(cpu))