]> git.ipfire.org Git - thirdparty/dracut.git/commitdiff
test: do not omit dracut networking modules
authorLaszlo Gombos <laszlo.gombos@gmail.com>
Fri, 25 Nov 2022 03:04:26 +0000 (03:04 +0000)
committerAntonio Álvarez Feijoo <antonio.feijoo@suse.com>
Wed, 7 Dec 2022 16:14:42 +0000 (17:14 +0100)
The main motivation of this change is to prepare to enable
testing all four networking dracut modules not just two.

There are four networking modules supported currently.
Omitting one networking module not only is not necessary but
confusing as if the test really wants to omit networking modules,
it should omit all three non-used dracut networking modules.

test/TEST-20-NFS/test.sh
test/TEST-30-ISCSI/test.sh
test/TEST-35-ISCSI-MULTI/test.sh
test/TEST-40-NBD/test.sh
test/TEST-50-MULTINIC/test.sh
test/TEST-60-BONDBRIDGEVLANIFCFG/test.sh

index 0467c49aa8a48e97e5a0c6195a1d0bfa3e6eeee0..5d3ab147b1c52d1b5e7fab904cf69591b70a303a 100755 (executable)
@@ -2,10 +2,8 @@
 
 if [[ $NM ]]; then
     USE_NETWORK="network-manager"
-    OMIT_NETWORK="network-legacy"
 else
     USE_NETWORK="network-legacy"
-    OMIT_NETWORK="network-manager"
 fi
 
 # shellcheck disable=SC2034
@@ -407,7 +405,7 @@ test_setup() {
 
     # Make client's dracut image
     "$basedir"/dracut.sh -l -i "$TESTDIR"/overlay / \
-        -o "plymouth dash ${OMIT_NETWORK}" \
+        -o "plymouth dash" \
         -a "dmsquash-live debug watchdog ${USE_NETWORK}" \
         --no-hostonly-cmdline -N \
         -f "$TESTDIR"/initramfs.testing "$KVERSION" || return 1
index 07d8016d781cff5afef093046cd3ac417ddb420f..99e57a323b8f2e92efd626003ef060e91fdb4a47 100755 (executable)
@@ -2,10 +2,8 @@
 
 if [[ $NM ]]; then
     USE_NETWORK="network-manager"
-    OMIT_NETWORK="network-legacy"
 else
     USE_NETWORK="network-legacy"
-    OMIT_NETWORK="network-manager"
 fi
 
 # shellcheck disable=SC2034
@@ -316,7 +314,7 @@ test_setup() {
     )
     # Make client's dracut image
     "$basedir"/dracut.sh -l -i "$TESTDIR"/overlay / \
-        -o "dash plymouth dmraid nfs ${OMIT_NETWORK}" \
+        -o "dash plymouth dmraid nfs" \
         -a "debug ${USE_NETWORK}" \
         --no-hostonly-cmdline -N \
         -f "$TESTDIR"/initramfs.testing "$KVERSION" || return 1
index 9c4d48387273f3272fcfccd0ffe69006ffffd29e..f11b24acf70df35888c296b0f9884be9cc6697e9 100755 (executable)
@@ -2,10 +2,8 @@
 
 if [[ $NM ]]; then
     USE_NETWORK="network-manager"
-    OMIT_NETWORK="network-legacy"
 else
     USE_NETWORK="network-legacy"
-    OMIT_NETWORK="network-manager"
 fi
 
 # shellcheck disable=SC2034
@@ -328,7 +326,7 @@ test_setup() {
     )
     # Make client's dracut image
     "$basedir"/dracut.sh -l -i "$TESTDIR"/overlay / \
-        -o "dash plymouth dmraid nfs ${OMIT_NETWORK}" \
+        -o "dash plymouth dmraid nfs" \
         -a "debug ${USE_NETWORK}" \
         --no-hostonly-cmdline -N \
         -f "$TESTDIR"/initramfs.testing "$KVERSION" || return 1
index f5654e7f04c8de0f6ab16d5e11e2ad3a49fe433b..54ba5982cd02b9137a495fc52ff1e99a2c669d5d 100755 (executable)
@@ -2,10 +2,8 @@
 
 if [[ $NM ]]; then
     USE_NETWORK="network-manager"
-    OMIT_NETWORK="network-legacy"
 else
     USE_NETWORK="network-legacy"
-    OMIT_NETWORK="network-manager"
 fi
 
 # shellcheck disable=SC2034
@@ -486,7 +484,7 @@ test_setup() {
     )
 
     "$basedir"/dracut.sh -l -i "$TESTDIR"/overlay / \
-        -o "plymouth dash iscsi nfs ${OMIT_NETWORK}" \
+        -o "plymouth dash iscsi nfs" \
         -a "debug watchdog ${USE_NETWORK}" \
         --no-hostonly-cmdline -N \
         -f "$TESTDIR"/initramfs.testing "$KVERSION" || return 1
index 6f01e08181f793b0437f4265b9086fa5504d3f24..5a47b096c1126bf8a799b7b343732256ce70a222 100755 (executable)
@@ -2,10 +2,8 @@
 
 if [[ $NM ]]; then
     USE_NETWORK="network-manager"
-    OMIT_NETWORK="network-legacy"
 else
     USE_NETWORK="network-legacy"
-    OMIT_NETWORK="network-manager"
 fi
 
 # shellcheck disable=SC2034
@@ -354,7 +352,7 @@ test_setup() {
     )
     # Make client's dracut image
     "$basedir"/dracut.sh -l -i "$TESTDIR"/overlay / \
-        -o "ifcfg plymouth dash ${OMIT_NETWORK}" \
+        -o "ifcfg plymouth dash" \
         -a "debug watchdog ${USE_NETWORK}" \
         --no-hostonly-cmdline -N \
         -f "$TESTDIR"/initramfs.testing "$KVERSION" || return 1
index 408fcf60f907249c341a08be14f37156d936d68c..dc8dd62db3f4b88500f637f2b8a53ff69d8afb38 100755 (executable)
@@ -4,10 +4,8 @@
 
 if [[ $NM ]]; then
     USE_NETWORK="network-manager"
-    OMIT_NETWORK="network-legacy"
 else
     USE_NETWORK="network-legacy"
-    OMIT_NETWORK="network-manager"
 fi
 
 # shellcheck disable=SC2034
@@ -369,7 +367,7 @@ test_setup() {
     # Make client's dracut image
     "$basedir"/dracut.sh -l -i "$TESTDIR"/overlay / \
         --no-early-microcode \
-        -o "plymouth ${OMIT_NETWORK}" \
+        -o "plymouth" \
         -a "debug ${USE_NETWORK}" \
         --no-hostonly-cmdline -N \
         -f "$TESTDIR"/initramfs.testing "$KVERSION" || return 1