]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: amd: acp: acp70: Remove unnecessary if-check
authorThorsten Blum <thorsten.blum@linux.dev>
Mon, 24 Feb 2025 22:12:12 +0000 (23:12 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 25 Feb 2025 13:19:24 +0000 (13:19 +0000)
Since list_for_each_entry() expects the list to not be empty, the
iterator variable cannot be NULL and the unnecessary if-check can be
removed. Remove it and indent the code accordingly.

Compile-tested only.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20250224221214.199849-2-thorsten.blum@linux.dev
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp70.c

index ef3f6504bc7f5e5f152810fa64bdbc4b95d7e3e5..7f4ec3bfaeabd157abf8b70a44441e29b5201011 100644 (file)
@@ -230,18 +230,16 @@ static int __maybe_unused acp70_pcm_resume(struct device *dev)
 
        spin_lock(&adata->acp_lock);
        list_for_each_entry(stream, &adata->stream_list, list) {
-               if (stream) {
-                       substream = stream->substream;
-                       if (substream && substream->runtime) {
-                               buf_in_frames = (substream->runtime->buffer_size);
-                               buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
-                               config_pte_for_stream(adata, stream);
-                               config_acp_dma(adata, stream, buf_size);
-                               if (stream->dai_id)
-                                       restore_acp_i2s_params(substream, adata, stream);
-                               else
-                                       restore_acp_pdm_params(substream, adata);
-                       }
+               substream = stream->substream;
+               if (substream && substream->runtime) {
+                       buf_in_frames = (substream->runtime->buffer_size);
+                       buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
+                       config_pte_for_stream(adata, stream);
+                       config_acp_dma(adata, stream, buf_size);
+                       if (stream->dai_id)
+                               restore_acp_i2s_params(substream, adata, stream);
+                       else
+                               restore_acp_pdm_params(substream, adata);
                }
        }
        spin_unlock(&adata->acp_lock);