]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
bnxt_en: hide CONFIG_DETECT_HUNG_TASK specific code
authorArnd Bergmann <arnd@arndb.de>
Wed, 23 Apr 2025 16:28:21 +0000 (18:28 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 23 Apr 2025 21:46:00 +0000 (14:46 -0700)
The CONFIG_DEFAULT_HUNG_TASK_TIMEOUT setting is only available when the
hung task detection is enabled, otherwise the code now produces a build
failure:

drivers/net/ethernet/broadcom/bnxt/bnxt.c:10188:21: error: use of undeclared identifier 'CONFIG_DEFAULT_HUNG_TASK_TIMEOUT'
 10188 |             max_tmo_secs > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT) {

Enclose this warning logic in an #ifdef to ensure this builds.

Fixes: 0fcad44a86bd ("bnxt_en: Change FW message timeout warning")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250423162827.2189658-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index ad30445b47998405345004283d6b0fadad517847..18359fabe0876de2428def10d263e0304482bbcc 100644 (file)
@@ -10184,11 +10184,13 @@ static int bnxt_hwrm_ver_get(struct bnxt *bp)
        if (!bp->hwrm_cmd_max_timeout)
                bp->hwrm_cmd_max_timeout = HWRM_CMD_MAX_TIMEOUT;
        max_tmo_secs = bp->hwrm_cmd_max_timeout / 1000;
+#ifdef CONFIG_DETECT_HUNG_TASK
        if (bp->hwrm_cmd_max_timeout > HWRM_CMD_MAX_TIMEOUT ||
            max_tmo_secs > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT) {
                netdev_warn(bp->dev, "Device requests max timeout of %d seconds, may trigger hung task watchdog (kernel default %ds)\n",
                            max_tmo_secs, CONFIG_DEFAULT_HUNG_TASK_TIMEOUT);
        }
+#endif
 
        if (resp->hwrm_intf_maj_8b >= 1) {
                bp->hwrm_max_req_len = le16_to_cpu(resp->max_req_win_len);