Apply suggestions from code review

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

diff --git a/pdns/rec_channel_rec.cc b/pdns/rec_channel_rec.cc
index 4c124160e7b566f2b0f91bc8fb9c3fb828e46133..83a5780fc715db999b13a73a3ca1517b6a5bdbce 100644 (file)
--- a/pdns/rec_channel_rec.cc
+++ b/pdns/rec_channel_rec.cc
@@ -1910,7 +1910,7 @@ RecursorControlChannel::Answer RecursorControlParser::getAnswer(int s, const str
             "dump-non-resolving <filename>    dump non-resolving nameservers addresses to the named file\n"
             "dump-nsspeeds <filename>         dump nsspeeds statistics to the named file\n"
             "dump-saved-parent-ns-sets <filename>\n"
-            "                                 dump saved parent ns sets that were used successfully as fallback\n"
+            "                                 dump saved parent ns sets that were successfully used as fallback\n"
             "dump-rpz <zone name> <filename>  dump the content of a RPZ zone to the named file\n"
             "dump-throttlemap <filename>      dump the contents of the throttle map to the named file\n"
             "get [key1] [key2] ..             get specific statistics\n"

diff --git a/pdns/recursordist/docs/appendices/internals.rst b/pdns/recursordist/docs/appendices/internals.rst
index 1d7d46a9938655c13673c2d001c984818bb634af..fcbafeaad604051692c3efc71b788f6c7f30cc2d 100644 (file)
--- a/pdns/recursordist/docs/appendices/internals.rst
+++ b/pdns/recursordist/docs/appendices/internals.rst
@@ -447,7 +447,7 @@ respect.
 
 Starting with version 4.7.0, there is a mechanism to save the
 parent NS set if it contains *more* names than the child NS set.
-This allows fallback to the saved parent NS set on resolution errors
+This allows falling back to the saved parent NS set on resolution errors
 using the child specified NS set.
 As experience shows, this configuration error is encountered in the
 wild often enough to warrant this workaround.

diff --git a/pdns/recursordist/docs/manpages/rec_control.1.rst b/pdns/recursordist/docs/manpages/rec_control.1.rst
index 22a3f1bd8560aaca0034796232ff5bcc6e6faa24..38f826a63e2fcba3cfeefb530f57c99c440e313a 100644 (file)
--- a/pdns/recursordist/docs/manpages/rec_control.1.rst
+++ b/pdns/recursordist/docs/manpages/rec_control.1.rst
@@ -123,9 +123,9 @@ dump-rpz *ZONE NAME* *FILE NAME*
 
 dump-saved-parent-ns-sets *FILE NAME*
     Dump the entries of the map containing saved parent NS sets
-    that were used successfully in resolving.
+    that were successfully used in resolving.
     The total number of entries is also printed in the header.
-    An entry is saved if the recursor sees that parent set includes
+    An entry is saved if the recursor sees that the parent set includes
     names not in the child set. This is an indication of a
     misconfigured domain.
 

diff --git a/pdns/recursordist/docs/upgrade.rst b/pdns/recursordist/docs/upgrade.rst
index 0bd399538aeb48df4e0bb4d205ca5c6c24bedf2b..17fc67694b4ee3729e1a7032c7d28549253eaea0 100644 (file)
--- a/pdns/recursordist/docs/upgrade.rst
+++ b/pdns/recursordist/docs/upgrade.rst
@@ -20,7 +20,7 @@ This has the consequence that authoritative nameservers will be contacted over I
 
 New settings
 ^^^^^^^^^^^^
-- The :ref:`settings-save-parent-ns-set` setting has been introduced, enabling fall-back cases if the parent ``NS`` set contains names not in the child ``NS`` set.
+- The :ref:`settings-save-parent-ns-set` setting has been introduced, enabling fallback cases if the parent ``NS`` set contains names not in the child ``NS`` set.
 
 Deprecated and changed settings
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^