]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: seq: Make dependency on UMP clearer
authorTakashi Iwai <tiwai@suse.de>
Wed, 1 Jan 2025 12:55:47 +0000 (13:55 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 1 Jan 2025 12:56:48 +0000 (13:56 +0100)
CONFIG_SND_SEQ_UMP_CLIENT is a Kconfig for a sequencer client
corresponding to the UMP rawmidi, while we have another major knob
CONFIG_SND_SEQ_UMP that specifies whether the sequencer core supports
UMP packets or not.  Strictly speaking both of them are independent,
but practically seen, it makes no sense to enable
CONFIG_SND_SEQ_UMP_CLIENT without UMP support itself.

This patch makes such an implicit dependency clearer.  Now
CONFIG_SND_SEQ_UMP_CLIENT depends on both CONFIG_SND_UMP and
CONFIG_SND_SEQ_UMP.  Meanwhile, CONFIG_SND_SEQ_UMP is enabled as
default when CONFIG_SND_UMP is set.

Fixes: 81fd444aa371 ("ALSA: seq: Bind UMP device")
Link: https://patch.msgid.link/20250101125548.25961-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/Kconfig

index 0374bbf51cd4d38af3564d25d82fe27d4ad5a08a..e4f58cb985d47cb8007b41ad2375495eb729ede1 100644 (file)
@@ -62,7 +62,7 @@ config SND_SEQ_VIRMIDI
 
 config SND_SEQ_UMP
        bool "Support for UMP events"
-       default y if SND_SEQ_UMP_CLIENT
+       default SND_UMP
        help
          Say Y here to enable the support for handling UMP (Universal MIDI
          Packet) events via ALSA sequencer infrastructure, which is an
@@ -71,6 +71,6 @@ config SND_SEQ_UMP
          among legacy and UMP clients.
 
 config SND_SEQ_UMP_CLIENT
-       def_tristate SND_UMP
+       def_tristate SND_UMP && SND_SEQ_UMP
 
 endif # SND_SEQUENCER