]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: iwlwifi: mvm: Fix bit size calculation in iwl_dbgfs_tas_get_status_read
authorPagadala Yesu Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>
Sat, 8 Mar 2025 21:19:20 +0000 (23:19 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 11 Mar 2025 09:54:02 +0000 (10:54 +0100)
Corrected the bit size calculation in the for_each_set_bit macro in
the iwl_dbgfs_tas_get_status_read(). The previous implementation used
sizeof(dyn_status), which only accounts for the number of bytes.
This has been updated to TAS_DYNA_STATUS_MAX to ensure the loop iterates
over the correct number of valid bits in dyn_status.

Signed-off-by: Pagadala Yesu Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250308231427.65d373e4a10e.If2cea63035333b07849e5a2c2a4f5dc5c5239595@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c

index 6ffc04a23c6c1092f2605fd4d9425dbc5fabb786..1289ff3ab162db1531964a4ebccce51a68a69db4 100644 (file)
@@ -698,11 +698,9 @@ static ssize_t iwl_dbgfs_tas_get_status_read(struct file *file,
 
                pos += scnprintf(pos, endpos - pos, "Dynamic status:\n");
                dyn_status = (rsp->tas_status_mac[i].dynamic_status);
-               for_each_set_bit(tmp, &dyn_status, sizeof(dyn_status)) {
-                       if (tmp >= 0 && tmp < TAS_DYNA_STATUS_MAX)
-                               pos += scnprintf(pos, endpos - pos,
-                                                "\t%s (%d)\n",
-                                                tas_current_status[tmp], tmp);
+               for_each_set_bit(tmp, &dyn_status, TAS_DYNA_STATUS_MAX) {
+                       pos += scnprintf(pos, endpos - pos, "\t%s (%d)\n",
+                                        tas_current_status[tmp], tmp);
                }
 
                pos += scnprintf(pos, endpos - pos,