]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/mediatek: mtk_hdmi: Remove ifdef for CONFIG_PM_SLEEP
authorAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Mon, 17 Feb 2025 15:48:23 +0000 (16:48 +0100)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Thu, 20 Feb 2025 14:13:13 +0000 (14:13 +0000)
Since the SIMPLE_DEV_PM_OPS macro and the pm pointer are anyway
defined when CONFIG_PM_SLEEP is not set, remove the ifdef for it
and indicate that the mtk_hdmi_{remove,suspend} functions may be
unused (as they are, in case PM support is not built-in).

While at it, to improve readability, also compress the
SIMPLE_DEV_PM_OPS declaration as it even fits in less
than 80 columns.

Reviewed-by: CK Hu <ck.hu@mediatek.com>
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20250217154836.108895-31-angelogioacchino.delregno@collabora.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_hdmi.c

index 4035666f8f6a154f213a2a9f710b3e53ff1fbbc2..2ff025e9151bd5ae38202c152e96fd1bd653ec2a 100644 (file)
@@ -1750,8 +1750,7 @@ static void mtk_hdmi_remove(struct platform_device *pdev)
        mtk_hdmi_clk_disable_audio(hdmi);
 }
 
-#ifdef CONFIG_PM_SLEEP
-static int mtk_hdmi_suspend(struct device *dev)
+static __maybe_unused int mtk_hdmi_suspend(struct device *dev)
 {
        struct mtk_hdmi *hdmi = dev_get_drvdata(dev);
 
@@ -1760,7 +1759,7 @@ static int mtk_hdmi_suspend(struct device *dev)
        return 0;
 }
 
-static int mtk_hdmi_resume(struct device *dev)
+static __maybe_unused int mtk_hdmi_resume(struct device *dev)
 {
        struct mtk_hdmi *hdmi = dev_get_drvdata(dev);
        int ret = 0;
@@ -1773,9 +1772,8 @@ static int mtk_hdmi_resume(struct device *dev)
 
        return 0;
 }
-#endif
-static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops,
-                        mtk_hdmi_suspend, mtk_hdmi_resume);
+
+static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, mtk_hdmi_suspend, mtk_hdmi_resume);
 
 static const struct mtk_hdmi_conf mtk_hdmi_conf_mt2701 = {
        .tz_disabled = true,