BUG/MEDIUM: mux-h2: fix crash on idle-ping due to unwanted ABORT_NOW

An ABORT_NOW() was used during debugging idle-ping but was not removed
from the final code. This may cause crash, in particular when mixing
idle-ping with shorter http-request/http-keep-alive values.

Fix this situation by removing ABORT_NOW() statement.

This should fix github issue #3079.

This must be backported up to 3.2.

diff --git a/src/mux_h2.c b/src/mux_h2.c
index 65eb133e52c6f1868c21ab1f0f3ac363a146c2e8..9ae45d2611fe6fd10a7931ae743f445cd9eede9d 100644 (file)
--- a/src/mux_h2.c
+++ b/src/mux_h2.c
@@ -924,7 +924,6 @@ static void h2c_update_timeout(struct h2c *h2c)
                                        else if (h2c->flags & H2_CF_IDL_PING_SENT) {
                                                /* timer other than ping selected, remove ping flag to allow GOAWAY on expiration. */
                                                h2c->flags &= ~H2_CF_IDL_PING_SENT;
-                                               ABORT_NOW();
                                        }
                                }
                        }