]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
usb: storage: ene_ub6250: Fix right shift warnings
authorAbhishek Tamboli <abhishektamboli9@gmail.com>
Thu, 12 Sep 2024 14:52:47 +0000 (20:22 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 13 Sep 2024 05:40:22 +0000 (07:40 +0200)
Change bl_len from u16 to u32 to accommodate the necessary bit shifts.

Fix the following smatch warnings:

drivers/usb/storage/ene_ub6250.c:1509 ms_scsi_read_capacity() warn:
right shifting more than type allows 16 vs 24
drivers/usb/storage/ene_ub6250.c:1510 ms_scsi_read_capacity() warn:
right shifting more than type allows 16 vs 16

Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20240912145247.15544-1-abhishektamboli9@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/storage/ene_ub6250.c

index 73dd276ce59c6bdfc98ee747b49bab4815f71364..a4bfbecbf16c33fa052549caefb06aab3afeac49 100644 (file)
@@ -1484,7 +1484,7 @@ static int ms_scsi_mode_sense(struct us_data *us, struct scsi_cmnd *srb)
 static int ms_scsi_read_capacity(struct us_data *us, struct scsi_cmnd *srb)
 {
        u32   bl_num;
-       u16    bl_len;
+       u32    bl_len;
        unsigned int offset = 0;
        unsigned char    buf[8];
        struct scatterlist *sg = NULL;