]> git.ipfire.org Git - thirdparty/shadow.git/commitdiff
useradd: fix comparison sign for write_full() return
authorIker Pedrosa <ipedrosa@redhat.com>
Fri, 4 Oct 2024 13:02:59 +0000 (15:02 +0200)
committerSerge Hallyn <serge@hallyn.com>
Sat, 5 Oct 2024 02:01:58 +0000 (21:01 -0500)
I forgot to change the comparison sign that checks the return value of
write_full()

Closes: https://github.com/shadow-maint/shadow/issues/1072
Fixes: 8903b94c86c9 ("useradd: fix write_full() return value")
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2313559

Reported-by: <https://github.com/brown-midas>
Suggested-by: <https://github.com/brown-midas>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
src/useradd.c

index b214205786d4ea950500ccbdcac84405668f8d29..64e7a412eed15a6a750386056823d06077c74e48 100644 (file)
@@ -2042,7 +2042,7 @@ static void lastlog_reset (uid_t uid)
                return;
        }
        if (   (lseek (fd, offset_uid, SEEK_SET) != offset_uid)
-           || (write_full (fd, &ll, sizeof (ll)) != -1)
+           || (write_full (fd, &ll, sizeof (ll)) == -1)
            || (fsync (fd) != 0)) {
                fprintf (stderr,
                         _("%s: failed to reset the lastlog entry of UID %lu: %s\n"),