]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check
authorRichard Henderson <richard.henderson@linaro.org>
Fri, 10 Jan 2020 14:54:18 +0000 (14:54 +0000)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 25 Jan 2020 17:18:50 +0000 (12:18 -0500)
We must not use the pointer output without validating the
success of the random read.

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20200110145422.49141-7-broonie@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
include/linux/random.h

index ea0e2f5f1ec5c46db3c93a8deb10a021399ea1f9..d319f9a1e4290efbeec9bd6dc8afbb4223df0dc4 100644 (file)
@@ -167,19 +167,19 @@ static inline void prandom_seed_state(struct rnd_state *state, u64 seed)
 #ifdef CONFIG_ARCH_RANDOM
 # include <asm/archrandom.h>
 #else
-static inline bool arch_get_random_long(unsigned long *v)
+static inline bool __must_check arch_get_random_long(unsigned long *v)
 {
        return false;
 }
-static inline bool arch_get_random_int(unsigned int *v)
+static inline bool __must_check arch_get_random_int(unsigned int *v)
 {
        return false;
 }
-static inline bool arch_get_random_seed_long(unsigned long *v)
+static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
 {
        return false;
 }
-static inline bool arch_get_random_seed_int(unsigned int *v)
+static inline bool __must_check arch_get_random_seed_int(unsigned int *v)
 {
        return false;
 }