]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
interconnect: qcom: icc-rpm: Fix peak rate calculation
authorBjorn Andersson <quic_bjorande@quicinc.com>
Tue, 5 Dec 2023 22:14:00 +0000 (14:14 -0800)
committerGeorgi Djakov <djakov@kernel.org>
Wed, 6 Dec 2023 15:00:42 +0000 (17:00 +0200)
Per the commit message of commit 'dd014803f260 ("interconnect: qcom:
icc-rpm: Add AB/IB calculations coefficients")', the peak rate should be
100/ib_percent. But, in what looks like a typical typo, the numerator
value is discarded in the calculation.

Update the implementation to match the described intention.

Fixes: dd014803f260 ("interconnect: qcom: icc-rpm: Add AB/IB calculations coefficients")
Cc: stable@vger.kernel.org
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20231205-qcom_icc_calc_rate-typo-v1-1-9d4378dcf53e@quicinc.com
Signed-off-by: Georgi Djakov <djakov@kernel.org>
drivers/interconnect/qcom/icc-rpm.c

index 628e651c555cb0aaf0003b79d3897ebbd989fbe4..dbacb2a7af508f5b330e8cc00c87b10ac09b55b4 100644 (file)
@@ -307,7 +307,7 @@ static u64 qcom_icc_calc_rate(struct qcom_icc_provider *qp, struct qcom_icc_node
 
        if (qn->ib_coeff) {
                agg_peak_rate = qn->max_peak[ctx] * 100;
-               agg_peak_rate = div_u64(qn->max_peak[ctx], qn->ib_coeff);
+               agg_peak_rate = div_u64(agg_peak_rate, qn->ib_coeff);
        } else {
                agg_peak_rate = qn->max_peak[ctx];
        }