]> git.ipfire.org Git - people/arne_f/kernel.git/commitdiff
exportfs: fix 'passing zero to ERR_PTR()' warning
authorYueHaibing <yuehaibing@huawei.com>
Mon, 19 Nov 2018 03:32:41 +0000 (11:32 +0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Mon, 19 Nov 2018 04:47:56 +0000 (23:47 -0500)
Fix a static code checker warning:
  fs/exportfs/expfs.c:171 reconnect_one() warn: passing zero to 'ERR_PTR'

The error path for lookup_one_len_unlocked failure
should set err to PTR_ERR.

Fixes: bbf7a8a3562f ("exportfs: move most of reconnect_path to helper function")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/exportfs/expfs.c

index 645158dc33f1fc86bfcca570361002c540068584..c8a3dfda176467329648ba9a5f261d10bd61070c 100644 (file)
@@ -147,6 +147,7 @@ static struct dentry *reconnect_one(struct vfsmount *mnt,
        tmp = lookup_one_len_unlocked(nbuf, parent, strlen(nbuf));
        if (IS_ERR(tmp)) {
                dprintk("%s: lookup failed: %d\n", __func__, PTR_ERR(tmp));
+               err = PTR_ERR(tmp);
                goto out_err;
        }
        if (tmp != dentry) {