]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86: classmate-laptop: Replace snprintf in show functions with sysfs_emit
authorHongling Zeng <zenghongling@kylinos.cn>
Sat, 19 Oct 2024 05:44:26 +0000 (13:44 +0800)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 21 Oct 2024 10:40:12 +0000 (13:40 +0300)
show() must not use snprintf() when formatting the value to be
returned to user space.

Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
Link: https://lore.kernel.org/r/20241019054426.8182-1-zenghongling@kylinos.cn
[ij: Added linux/sysfs.h include]
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/classmate-laptop.c

index cb6fce655e35b3af2f2f97dafa5b0886192576ca..6b1b8e444e241cd0f0b544ecddd27f5d4c04a4f9 100644 (file)
@@ -12,6 +12,7 @@
 #include <linux/backlight.h>
 #include <linux/input.h>
 #include <linux/rfkill.h>
+#include <linux/sysfs.h>
 
 struct cmpc_accel {
        int sensitivity;
@@ -208,7 +209,7 @@ static ssize_t cmpc_accel_sensitivity_show_v4(struct device *dev,
        inputdev = dev_get_drvdata(&acpi->dev);
        accel = dev_get_drvdata(&inputdev->dev);
 
-       return sprintf(buf, "%d\n", accel->sensitivity);
+       return sysfs_emit(buf, "%d\n", accel->sensitivity);
 }
 
 static ssize_t cmpc_accel_sensitivity_store_v4(struct device *dev,
@@ -257,7 +258,7 @@ static ssize_t cmpc_accel_g_select_show_v4(struct device *dev,
        inputdev = dev_get_drvdata(&acpi->dev);
        accel = dev_get_drvdata(&inputdev->dev);
 
-       return sprintf(buf, "%d\n", accel->g_select);
+       return sysfs_emit(buf, "%d\n", accel->g_select);
 }
 
 static ssize_t cmpc_accel_g_select_store_v4(struct device *dev,
@@ -550,7 +551,7 @@ static ssize_t cmpc_accel_sensitivity_show(struct device *dev,
        inputdev = dev_get_drvdata(&acpi->dev);
        accel = dev_get_drvdata(&inputdev->dev);
 
-       return sprintf(buf, "%d\n", accel->sensitivity);
+       return sysfs_emit(buf, "%d\n", accel->sensitivity);
 }
 
 static ssize_t cmpc_accel_sensitivity_store(struct device *dev,