]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
schannel: add clarifying comment
authorDaniel Stenberg <daniel@haxx.se>
Tue, 11 Apr 2023 12:40:46 +0000 (14:40 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Tue, 11 Apr 2023 21:50:49 +0000 (23:50 +0200)
Explaining how the PVS warning in #10929 is wrong: Dereferencing of the
null pointer 'backend->cred' might take place.

Closes #10931

lib/vtls/schannel.c

index 6f94c7e34950f3a819a7374d49e0949f2630f248..430a41c13d7e2a61f58866a4556931a96bf5c094 100644 (file)
@@ -1171,9 +1171,11 @@ schannel_connect_step1(struct Curl_cfilter *cf, struct Curl_easy *data)
   if(!backend->cred) {
     char *snihost;
     result = schannel_acquire_credential_handle(cf, data);
-    if(result != CURLE_OK) {
+    if(result)
       return result;
-    }
+    /* schannel_acquire_credential_handle() sets backend->cred accordingly or
+       it returns error otherwise. */
+
     /* A hostname associated with the credential is needed by
        InitializeSecurityContext for SNI and other reasons. */
     snihost = Curl_ssl_snihost(data, hostname, NULL);