imap-zlib: Removed check for disallowing COMPRESS to be used with TLS compression.

Clients shouldn't be doing this in any case, and this check doesn't work
properly with proxies.

We could solve the check properly for Dovecot proxies by having them send
the TLS compression state to backends, but it would still leave non-Dovecot
proxies broken. Although we could just not advertise COMPRESS=DEFLATE
extension if TLS compression is enabled and non-Dovecot proxies at least
wouldn't cause failures. Still, overall seems like a lot of work for such a
small and probably unnecessary extra check.

diff --git a/src/plugins/imap-zlib/imap-zlib-plugin.c b/src/plugins/imap-zlib/imap-zlib-plugin.c
index 48852ab9cbf91f08fa8acd66b3cbebddf412d26c..631842b73d90c842b85717daa530b3897ff2a7e4 100644 (file)
--- a/src/plugins/imap-zlib/imap-zlib-plugin.c
+++ b/src/plugins/imap-zlib/imap-zlib-plugin.c
@@ -87,11 +87,6 @@ static bool cmd_compress(struct client_command_context *cmd)
                        t_str_ucase(zclient->handler->name)));
                return TRUE;
        }
-       if (client->tls_compression) {
-               client_send_tagline(cmd,
-                       "NO [COMPRESSIONACTIVE] TLS compression already enabled.");
-               return TRUE;
-       }
 
        handler = compression_lookup_handler(t_str_lcase(mechanism));
        if (handler == NULL || handler->create_istream == NULL) {