msvc: avoid calling `access("NUL", flags)`

Apparently this is not supported with Microsoft's Universal C Runtime.
So let's not actually do that.

Instead, just return success because we _know_ that we expect the `NUL`
device to be present.

Side note: it is possible to turn off the "Null device driver" and
thereby disable `NUL`. Too many things are broken if this driver is
disabled, therefore it is not worth bothering to try to detect its
presence when `access()` is called.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/compat/mingw.c b/compat/mingw.c
index a43599841c6c6bb3e4312d53e35647ed0c8af3fb..aa647b367b0fab393f5309bbb1dac3627383b1e5 100644 (file)
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -685,6 +685,8 @@ ssize_t mingw_write(int fd, const void *buf, size_t len)
 int mingw_access(const char *filename, int mode)
 {
        wchar_t wfilename[MAX_PATH];
+       if (!strcmp("nul", filename) || !strcmp("/dev/null", filename))
+               return 0;
        if (xutftowcs_path(wfilename, filename) < 0)
                return -1;
        /* X_OK is not supported by the MSVCRT version */