]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bus: bt1-axi: Use sysfs_streq instead of strncmp
authorSerge Semin <Sergey.Semin@baikalelectronics.ru>
Thu, 28 May 2020 14:50:50 +0000 (17:50 +0300)
committerArnd Bergmann <arnd@arndb.de>
Thu, 28 May 2020 14:57:12 +0000 (16:57 +0200)
There is a ready-to-use method to compare a retrieved from a sysfs node
string with another string. It treats both NUL and newline-then-NUL as
equivalent string terminations. So use it instead of manually truncating
the line length in the strncmp() method.

Link: https://lore.kernel.org/r/20200528145050.5203-6-Sergey.Semin@baikalelectronics.ru
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
Cc: Olof Johansson <olof@lixom.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: soc@kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/bus/bt1-axi.c

index c194d9a2bbeb53bcc74e8e749b8db5ac23e302f3..e7a6744acc7b82e1292edf0138d29ab24a1c1946 100644 (file)
@@ -220,9 +220,9 @@ static ssize_t inject_error_store(struct device *dev,
         * error while unaligned writing - the AXI bus write error handled
         * by this driver.
         */
-       if (!strncmp(data, "bus", 3))
+       if (sysfs_streq(data, "bus"))
                readb(axi->qos_regs);
-       else if (!strncmp(data, "unaligned", 9))
+       else if (sysfs_streq(data, "unaligned"))
                writeb(0, axi->qos_regs);
        else
                return -EINVAL;