smbd: Fix Coverity ID 1635770: avoid NULL deref of reparse

Commit 6d71edab5a ("smbd: use fsctl_get_reparse_point() in
smb3_file_posix_information_init()") introduced the local helper
function reparse_buffer_parse_posix_type; when this function enter the
case where 'reparse_tag != IO_REPARSE_TAG_NFS' the local variable
reparse is still NULL, and must not be de-referenced in DBG_INFO print.

Fixes Coverity issue 1635770

Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Mon Jun  9 06:26:05 UTC 2025 on atb-devel-224

diff --git a/source3/smbd/smb2_posix.c b/source3/smbd/smb2_posix.c
index 8797b266260afde888400d09c2c90cdecc8f4f0f..d2313696dd6d0c1d074f5ea1604ef92381b29796 100644 (file)
--- a/source3/smbd/smb2_posix.c
+++ b/source3/smbd/smb2_posix.c
@@ -44,7 +44,7 @@ static NTSTATUS reparse_buffer_parse_posix_type(uint32_t reparse_tag,
                 * anything that is not a NFS one (or symlink) as S_IFREG.
                 */
                DBG_INFO("Unhandled NFS reparse tag: 0x%" PRIx32 "\n",
-                        reparse->tag);
+                        reparse_tag);
                *type = S_IFREG;
                return NT_STATUS_OK;
        }