]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: fsl: mpc5200: signed parameter in snprintf format
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 19 Feb 2021 23:29:35 +0000 (17:29 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:06:41 +0000 (13:06 +0000)
cppcheck warning:

sound/soc/fsl/mpc5200_dma.c:414:2: warning: %u in format
string (no. 1) requires 'unsigned int' but the argument type is
'signed int'. [invalidPrintfArgType_uint]
 snprintf(psc_dma->name, sizeof psc_dma->name, "PSC%u", psc_dma->id);
 ^

Also fix sizeof use, missing parentheses reported by checkpatch.pl

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210219232937.6440-8-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/mpc5200_dma.c

index 23198488217628e8f988d25adaef8e11cdb809de..6c65cd858b0b09b5bbcca1cb4b77243751e447e8 100644 (file)
@@ -411,7 +411,7 @@ int mpc5200_audio_dma_create(struct platform_device *op)
        psc_dma->dev = &op->dev;
        psc_dma->playback.psc_dma = psc_dma;
        psc_dma->capture.psc_dma = psc_dma;
-       snprintf(psc_dma->name, sizeof psc_dma->name, "PSC%u", psc_dma->id);
+       snprintf(psc_dma->name, sizeof(psc_dma->name), "PSC%d", psc_dma->id);
 
        /* Find the address of the fifo data registers and setup the
         * DMA tasks */