]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/cirrus: Use non-hybrid PCI devres API
authorPhilipp Stanner <phasta@kernel.org>
Thu, 17 Apr 2025 09:40:10 +0000 (11:40 +0200)
committerPhilipp Stanner <phasta@kernel.org>
Fri, 9 May 2025 08:34:40 +0000 (10:34 +0200)
cirrus enables its PCI device with pcim_enable_device(). This,
implicitly, switches the function pci_request_regions() into managed
mode, where it becomes a devres function.

The PCI subsystem wants to remove this hybrid nature from its
interfaces. To do so, users of the aforementioned combination of
functions must be ported to non-hybrid functions.

Replace the call to sometimes-managed pci_request_regions() with one to
the always-managed pcim_request_all_regions().

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://lore.kernel.org/r/20250417094009.29297-2-phasta@kernel.org
drivers/gpu/drm/tiny/cirrus-qemu.c

index ccf3f6551344a8421fb69ce1cc84b7cedc5b53b4..97a93adc5669d7ae9f1ef37bd7bf3130d4e3695d 100644 (file)
@@ -578,7 +578,7 @@ static int cirrus_pci_probe(struct pci_dev *pdev,
        if (ret)
                return ret;
 
-       ret = pci_request_regions(pdev, DRIVER_NAME);
+       ret = pcim_request_all_regions(pdev, DRIVER_NAME);
        if (ret)
                return ret;