]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
psplash: consider the situation of psplash not exist for systemd
authorChen Qi <Qi.Chen@windriver.com>
Thu, 1 Dec 2022 05:00:50 +0000 (21:00 -0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 23 Dec 2022 23:04:57 +0000 (23:04 +0000)
In current psplash framework, the psplash might not exist at all.
For example, in case DSITRO is set to nodistro, the psplash does
not exist.

In our psplash recipe, we have:
SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
This variable is parsed to if psplash-poky-img.h exists, a package
named psplash-default is created and is added to RDEPENDS:${PN}.

We can see that the psplash-poky-img.h resides in meta-poky,
and in psplash_git.bbappend file in meta-poky, we have:
FILESEXTRAPATHS:prepend:poky := "${THISDIR}/files:"
So this file is only available in case poky distro is used.

To fix this issue, add condition check in the corresponding systemd
services.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
(cherry picked from commit 7a62ff9ed39c179d2b9b0c40f4f8423ced413063)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/recipes-core/psplash/files/psplash-start.service
meta/recipes-core/psplash/files/psplash-systemd.service

index 36c2bb38e0722f05020e6d31ee6ab4286009937b..bec9368427a4a6703962a42513eb5803564bbeaf 100644 (file)
@@ -2,6 +2,7 @@
 Description=Start psplash boot splash screen
 DefaultDependencies=no
 RequiresMountsFor=/run
+ConditionFileIsExecutable=/usr/bin/psplash
 
 [Service]
 Type=notify
index 082207f2324aae3a1a516ea11dd91446a3148dd7..e93e3deb35aa386eea6076ff97582871a1a26469 100644 (file)
@@ -4,6 +4,7 @@ DefaultDependencies=no
 After=psplash-start.service
 Requires=psplash-start.service
 RequiresMountsFor=/run
+ConditionFileIsExecutable=/usr/bin/psplash
 
 [Service]
 ExecStart=/usr/bin/psplash-systemd