]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
nfsd: don't set SVC_SOCK_ANONYMOUS when creating nfsd sockets
authorJeff Layton <jlayton@kernel.org>
Fri, 19 Jul 2024 18:55:53 +0000 (14:55 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 22 Jul 2024 13:47:39 +0000 (09:47 -0400)
When creating nfsd sockets via the netlink interface, we do want to
register with the portmapper. Don't set SVC_SOCK_ANONYMOUS.

Reported-by: Steve Dickson <steved@redhat.com>
Fixes: 16a471177496 ("NFSD: add listener-{set,get} netlink command")
Cc: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfsctl.c

index 9e0ea6fc2aa326c5413d792743a330ee5eec68f9..34eb2c2cbcde34377a347efe7a5e2dbffe552053 100644 (file)
@@ -2069,8 +2069,7 @@ int nfsd_nl_listener_set_doit(struct sk_buff *skb, struct genl_info *info)
                        continue;
                }
 
-               ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa,
-                                             SVC_SOCK_ANONYMOUS,
+               ret = svc_xprt_create_from_sa(serv, xcl_name, net, sa, 0,
                                              get_current_cred());
                /* always save the latest error */
                if (ret < 0)