]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lmtp: Always read settings before dropping privs
authorAki Tuomi <aki.tuomi@dovecot.fi>
Wed, 7 Sep 2016 19:06:55 +0000 (22:06 +0300)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Fri, 9 Sep 2016 11:22:04 +0000 (14:22 +0300)
If lmtp is ran explicitly as root, settings were not read.

src/lmtp/main.c

index b6d2a5d082f8b678e7955f428fc3c7dd25fe45ac..61a64e5aa60e68673e7d0f63280db78e2f4f06cb 100644 (file)
@@ -42,17 +42,15 @@ static void drop_privileges(void)
 
        /* by default we don't drop any privileges, but keep running as root. */
        restrict_access_get_env(&set);
-       if (set.uid != 0) {
-               /* open config connection before dropping privileges */
-               struct master_service_settings_input input;
-               struct master_service_settings_output output;
-
-               memset(&input, 0, sizeof(input));
-               input.module = "lmtp";
-               input.service = "lmtp";
-               (void)master_service_settings_read(master_service,
-                                                  &input, &output, &error);
-       }
+       /* open config connection before dropping privileges */
+       struct master_service_settings_input input;
+       struct master_service_settings_output output;
+
+       memset(&input, 0, sizeof(input));
+       input.module = "lmtp";
+       input.service = "lmtp";
+       (void)master_service_settings_read(master_service,
+                                          &input, &output, &error);
        restrict_access_by_env(NULL, FALSE);
 }