]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: don't try to delete RAID stripe-extents if we don't need to
authorJohannes Thumshirn <johannes.thumshirn@wdc.com>
Mon, 13 Jan 2025 19:31:43 +0000 (20:31 +0100)
committerDavid Sterba <dsterba@suse.com>
Tue, 14 Jan 2025 14:48:46 +0000 (15:48 +0100)
Even if the RAID stripe-tree is not enabled in the filesystem,
do_free_extent_accounting() still calls into btrfs_delete_raid_extent().

Check if the extent in question is on a block-group that has a profile
which is used by RAID stripe-tree before attempting to delete a stripe
extent. Return early if it doesn't, otherwise we're doing a unnecessary
search.

Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/raid-stripe-tree.c

index 0bf3c032d9dc43eefe158e430813add9292c577e..be923144cc85a0ecb370dbb1ebeea44269a1f4ad 100644 (file)
@@ -59,9 +59,22 @@ int btrfs_delete_raid_extent(struct btrfs_trans_handle *trans, u64 start, u64 le
        int slot;
        int ret;
 
-       if (!stripe_root)
+       if (!btrfs_fs_incompat(fs_info, RAID_STRIPE_TREE) || !stripe_root)
                return 0;
 
+       if (!btrfs_is_testing(fs_info)) {
+               struct btrfs_chunk_map *map;
+               bool use_rst;
+
+               map = btrfs_find_chunk_map(fs_info, start, length);
+               if (!map)
+                       return -EINVAL;
+               use_rst = btrfs_need_stripe_tree_update(fs_info, map->type);
+               btrfs_free_chunk_map(map);
+               if (!use_rst)
+                       return 0;
+       }
+
        path = btrfs_alloc_path();
        if (!path)
                return -ENOMEM;