request: make Curl_req_init return void

Since it could not return error and therefore this change removes dead
code for the caller.

Spotted by CodeSonar.

Closes #13423

diff --git a/lib/request.c b/lib/request.c
index d1605d32a165fe67b6a869f04196e1389f19af6b..26741fa6cb5550d605c75cca188a1c6484bf6859 100644 (file)
--- a/lib/request.c
+++ b/lib/request.c
@@ -40,10 +40,9 @@
 #include "curl_memory.h"
 #include "memdebug.h"
 
-CURLcode Curl_req_init(struct SingleRequest *req)
+void Curl_req_init(struct SingleRequest *req)
 {
   memset(req, 0, sizeof(*req));
-  return CURLE_OK;
 }
 
 CURLcode Curl_req_soft_reset(struct SingleRequest *req,

diff --git a/lib/request.h b/lib/request.h
index 488fbdd4d91fb74116dddd44dce69c41dd73e546..f9be6f29935fa2d0d5c997ca3b29c9f9d7b24bb5 100644 (file)
--- a/lib/request.h
+++ b/lib/request.h
@@ -152,7 +152,7 @@ struct SingleRequest {
 /**
  * Initialize the state of the request for first use.
  */
-CURLcode Curl_req_init(struct SingleRequest *req);
+void Curl_req_init(struct SingleRequest *req);
 
 /**
  * The request is about to start. Record time and do a soft reset.

diff --git a/lib/url.c b/lib/url.c
index e11d80327cf7c21ed72bdb227895563aa0278347..fc3a4356e41ad547b40bae49c850aa6d17e75ab8 100644 (file)
--- a/lib/url.c
+++ b/lib/url.c
@@ -516,12 +516,7 @@ CURLcode Curl_open(struct Curl_easy **curl)
 
   data->magic = CURLEASY_MAGIC_NUMBER;
 
-  result = Curl_req_init(&data->req);
-  if(result) {
-    DEBUGF(fprintf(stderr, "Error: request init failed\n"));
-    free(data);
-    return result;
-  }
+  Curl_req_init(&data->req);
 
   result = Curl_resolver_init(data, &data->state.async.resolver);
   if(result) {