]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: ks8851: use %*ph to print small buffer
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 16 Oct 2024 13:25:26 +0000 (16:25 +0300)
committerAndrew Lunn <andrew@lunn.ch>
Thu, 17 Oct 2024 23:11:05 +0000 (18:11 -0500)
Use %*ph format to print small buffer as hex string. It will change
the output format from 32-bit words to byte hexdump, but this is not
critical as it's only a debug message.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Message-ID: <20241016132615.899037-1-andriy.shevchenko@linux.intel.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
drivers/net/ethernet/micrel/ks8851_common.c

index 7fa1820db9cce6eac06a8964c29cd5e9a396ed70..bb5138806c3ffd807bc405e8c758af79d5075f0e 100644 (file)
@@ -215,22 +215,6 @@ static void ks8851_init_mac(struct ks8851_net *ks, struct device_node *np)
        ks8851_write_mac_addr(dev);
 }
 
-/**
- * ks8851_dbg_dumpkkt - dump initial packet contents to debug
- * @ks: The device state
- * @rxpkt: The data for the received packet
- *
- * Dump the initial data from the packet to dev_dbg().
- */
-static void ks8851_dbg_dumpkkt(struct ks8851_net *ks, u8 *rxpkt)
-{
-       netdev_dbg(ks->netdev,
-                  "pkt %02x%02x%02x%02x %02x%02x%02x%02x %02x%02x%02x%02x\n",
-                  rxpkt[4], rxpkt[5], rxpkt[6], rxpkt[7],
-                  rxpkt[8], rxpkt[9], rxpkt[10], rxpkt[11],
-                  rxpkt[12], rxpkt[13], rxpkt[14], rxpkt[15]);
-}
-
 /**
  * ks8851_rx_pkts - receive packets from the host
  * @ks: The device information.
@@ -296,8 +280,8 @@ static void ks8851_rx_pkts(struct ks8851_net *ks, struct sk_buff_head *rxq)
 
                                ks->rdfifo(ks, rxpkt, rxalign + 8);
 
-                               if (netif_msg_pktdata(ks))
-                                       ks8851_dbg_dumpkkt(ks, rxpkt);
+                               netif_dbg(ks, pktdata, ks->netdev,
+                                         "pkt %12ph\n", &rxpkt[4]);
 
                                skb->protocol = eth_type_trans(skb, ks->netdev);
                                __skb_queue_tail(rxq, skb);