]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: phy: avoid genphy_c45_ethtool_get_eee() setting eee_enabled
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 5 Dec 2024 10:42:05 +0000 (10:42 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Dec 2024 01:47:31 +0000 (17:47 -0800)
genphy_c45_ethtool_get_eee() is only called from phy_ethtool_get_eee(),
which then calls eeecfg_to_eee(). eeecfg_to_eee() will overwrite
keee.eee_enabled, so there's no point setting keee.eee_enabled in
genphy_c45_ethtool_get_eee(). Remove this assignment.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/E1tJ9J7-006LIn-Jr@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/phy-c45.c

index 944ae98ad110608d25256e01a6413175dbc02008..d162f78bc68dbd491648a396c691acb481ec23d0 100644 (file)
@@ -1521,15 +1521,13 @@ EXPORT_SYMBOL(genphy_c45_eee_is_active);
 int genphy_c45_ethtool_get_eee(struct phy_device *phydev,
                               struct ethtool_keee *data)
 {
-       bool is_enabled;
        int ret;
 
        ret = genphy_c45_eee_is_active(phydev, data->advertised,
-                                      data->lp_advertised, &is_enabled);
+                                      data->lp_advertised, NULL);
        if (ret < 0)
                return ret;
 
-       data->eee_enabled = is_enabled;
        data->eee_active = phydev->eee_active;
        linkmode_copy(data->supported, phydev->supported_eee);