]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests: acct: Add ksft_exit_skip if not running as root
authorShivam Chaudhary <cvam0000@gmail.com>
Tue, 10 Dec 2024 12:32:12 +0000 (18:02 +0530)
committerShuah Khan <skhan@linuxfoundation.org>
Wed, 15 Jan 2025 00:06:31 +0000 (17:06 -0700)
If the selftest is not running as root, it should skip not
fail and give an appropriate warning to the user. This patch adds
ksft_exit_skip() if the test is not running as root.

Logs:

Before change:

TAP version 13
1..1
ok 1 # SKIP This test needs root to run!

After change:

TAP version 13
1..1
ok 2 # SKIP This test needs root to run!
Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0

Link: https://lore.kernel.org/r/20241210123212.332050-1-cvam0000@gmail.com
Signed-off-by: Shivam Chaudhary <cvam0000@gmail.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/acct/acct_syscall.c

index e44e8fe1f4a3c9acde7dc1132e9e4c2773958580..87c044fb929389a08e6adfcf4f7d60837f1e9803 100644 (file)
@@ -24,7 +24,7 @@ int main(void)
 
        // Check if test is run a root
        if (geteuid()) {
-               ksft_test_result_skip("This test needs root to run!\n");
+               ksft_exit_skip("This test needs root to run!\n");
                return 1;
        }