]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli: Simplify disp_sec_ace_object()
authorVolker Lendecke <vl@samba.org>
Thu, 28 Nov 2024 17:41:50 +0000 (18:41 +0100)
committerVolker Lendecke <vl@samba.org>
Tue, 17 Dec 2024 12:30:30 +0000 (12:30 +0000)
Directly use GUID_buf_string()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
libcli/security/display_sec.c

index be89a33f1761cb892e2538a6caa416421ae8a215..33fe77b8f25036a665b22b5a6975f958ecb52c3e 100644 (file)
@@ -110,20 +110,18 @@ void display_sec_ace_flags(uint8_t flags)
  ****************************************************************************/
 static void disp_sec_ace_object(struct security_ace_object *object)
 {
-       char *str;
+       struct GUID_txt_buf buf;
+
        if (object->flags & SEC_ACE_OBJECT_TYPE_PRESENT) {
-               str = GUID_string(NULL, &object->type.type);
-               if (str == NULL) return;
                printf("Object type: SEC_ACE_OBJECT_TYPE_PRESENT\n");
-               printf("Object GUID: %s\n", str);
-               talloc_free(str);
+               printf("Object GUID: %s\n",
+                      GUID_buf_string(&object->type.type, &buf));
        }
        if (object->flags & SEC_ACE_INHERITED_OBJECT_TYPE_PRESENT) {
-               str = GUID_string(NULL, &object->inherited_type.inherited_type);
-               if (str == NULL) return;
                printf("Object type: SEC_ACE_INHERITED_OBJECT_TYPE_PRESENT\n");
-               printf("Object GUID: %s\n", str);
-               talloc_free(str);
+               printf("Object GUID: %s\n",
+                      GUID_buf_string(&object->inherited_type.inherited_type,
+                                      &buf));
        }
 }