]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: iwlwifi: mvm: assume '1' as the default mac_config_cmd version
authorMiri Korenblit <miriam.rachel.korenblit@intel.com>
Tue, 24 Jun 2025 07:14:27 +0000 (10:14 +0300)
committerMiri Korenblit <miriam.rachel.korenblit@intel.com>
Tue, 24 Jun 2025 08:34:26 +0000 (11:34 +0300)
Unfortunately, FWs of some devices don't have the version of the
iwl_mac_config_cmd defined in the TLVs. We send 0 as the 'def argument
to  iwl_fw_lookup_cmd_ver, so for such FWs, the return value will be 0,
leading to a warning, and to not sending the command.

Fix this by assuming that the default version is 1.

Fixes: 83f3ac2848b4 ("wifi: iwlwifi: Fix incorrect logic on cmd_ver range checking")
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250624071427.2662621-1-miriam.rachel.korenblit@intel.com
drivers/net/wireless/intel/iwlwifi/mvm/mld-mac.c

index 3c255ae916c85740a0e789e7e8a2662c3119e6b5..3f8b840871d366b5c8e3dca9cebe3ef4bfef4e74 100644 (file)
@@ -32,9 +32,9 @@ static void iwl_mvm_mld_mac_ctxt_cmd_common(struct iwl_mvm *mvm,
        unsigned int link_id;
        int cmd_ver = iwl_fw_lookup_cmd_ver(mvm->fw,
                                            WIDE_ID(MAC_CONF_GROUP,
-                                                   MAC_CONFIG_CMD), 0);
+                                                   MAC_CONFIG_CMD), 1);
 
-       if (WARN_ON(cmd_ver < 1 || cmd_ver > 3))
+       if (WARN_ON(cmd_ver > 3))
                return;
 
        cmd->id_and_color = cpu_to_le32(mvmvif->id);