]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
crypto: qat/qat_420xx - fix off by one in uof_get_name()
authorDan Carpenter <dan.carpenter@linaro.org>
Sat, 28 Sep 2024 10:05:01 +0000 (13:05 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 5 Oct 2024 05:22:06 +0000 (13:22 +0800)
This is called from uof_get_name_420xx() where "num_objs" is the
ARRAY_SIZE() of fw_objs[].  The > needs to be >= to prevent an out of
bounds access.

Fixes: fcf60f4bcf54 ("crypto: qat - add support for 420xx devices")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c

index 78f0ea49254dbbd814d5b9614c1ab24fa1b45f8a..9faef33e54bd32b1165bef9a24f04dc06070db32 100644 (file)
@@ -375,7 +375,7 @@ static const char *uof_get_name(struct adf_accel_dev *accel_dev, u32 obj_num,
        else
                id = -EINVAL;
 
-       if (id < 0 || id > num_objs)
+       if (id < 0 || id >= num_objs)
                return NULL;
 
        return fw_objs[id];