]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: rtl8xxxu: Fix RTL8188EU firmware upload block size
authorBitterblue Smith <rtl8821cerfe2@gmail.com>
Mon, 23 Dec 2024 15:01:57 +0000 (17:01 +0200)
committerPing-Ke Shih <pkshih@realtek.com>
Mon, 30 Dec 2024 01:28:00 +0000 (09:28 +0800)
A user reports that the firmware upload consistently fails when it's
uploaded in chunks of 128 bytes, but it works when uploaded in chunks
of 196 bytes. The official driver uses 196 bytes also.

Link: https://github.com/a5a5aa555oo/rtl8xxxu/issues/2
Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/cba8e2f2-32c4-4174-90ba-0219f29dbdde@gmail.com
drivers/net/wireless/realtek/rtl8xxxu/8188e.c

index 3d04df0f5bf4bdd8e39b0e8a3711a7565b2206c8..766a7a7c7d281670c9ed0fde91d731a26db4ffd8 100644 (file)
@@ -1860,7 +1860,7 @@ struct rtl8xxxu_fileops rtl8188eu_fops = {
        .set_crystal_cap = rtl8188f_set_crystal_cap,
        .cck_rssi = rtl8188e_cck_rssi,
        .led_classdev_brightness_set = rtl8188eu_led_brightness_set,
-       .writeN_block_size = 128,
+       .writeN_block_size = 196,
        .rx_desc_size = sizeof(struct rtl8xxxu_rxdesc16),
        .tx_desc_size = sizeof(struct rtl8xxxu_txdesc32),
        .has_tx_report = 1,