]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm: huge_memory: use strscpy() instead of strcpy()
authorMaíra Canal <mcanal@igalia.com>
Fri, 1 Nov 2024 16:54:09 +0000 (13:54 -0300)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 11 Nov 2024 21:09:43 +0000 (13:09 -0800)
Replace strcpy() with strscpy() in mm/huge_memory.c

strcpy() has been deprecated because it is generally unsafe, so help to
eliminate it from the kernel source.

Link: https://github.com/KSPP/linux/issues/88
Link: https://lkml.kernel.org/r/20241101165719.1074234-7-mcanal@igalia.com
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Lance Yang <ioworker0@gmail.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Barry Song <baohua@kernel.org>
Cc: David Hildenbrand <david@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/huge_memory.c

index a6edbd8c4f495f134ddee93b4febee606c6c577e..1ebe18ec456075d2e4019beb72e7dc761b45ae9d 100644 (file)
@@ -969,7 +969,7 @@ static int __init setup_thp_anon(char *str)
 
        if (!str || strlen(str) + 1 > PAGE_SIZE)
                goto err;
-       strcpy(str_dup, str);
+       strscpy(str_dup, str);
 
        always = huge_anon_orders_always;
        madvise = huge_anon_orders_madvise;
@@ -4167,7 +4167,7 @@ static ssize_t split_huge_pages_write(struct file *file, const char __user *buf,
 
                tok = strsep(&buf, ",");
                if (tok) {
-                       strcpy(file_path, tok);
+                       strscpy(file_path, tok);
                } else {
                        ret = -EINVAL;
                        goto out;