]> git.ipfire.org Git - thirdparty/iptables.git/commitdiff
tests/shell: Test for fixed extension registration
authorPhil Sutter <phil@nwl.cc>
Fri, 4 Dec 2020 16:44:51 +0000 (17:44 +0100)
committerPhil Sutter <phil@nwl.cc>
Mon, 7 Dec 2020 14:47:20 +0000 (15:47 +0100)
Use strace to look at iptables-restore behaviour with typically
problematic input (conntrack revision 0 is no longer supported by
current kernels) to make sure the fix in commit a1eaaceb0460b
("libxtables: Simplify pending extension registration") is still
effective.

Signed-off-by: Phil Sutter <phil@nwl.cc>
iptables/tests/shell/testcases/ipt-restore/0017-pointless-compat-checks_0 [new file with mode: 0755]

diff --git a/iptables/tests/shell/testcases/ipt-restore/0017-pointless-compat-checks_0 b/iptables/tests/shell/testcases/ipt-restore/0017-pointless-compat-checks_0
new file mode 100755 (executable)
index 0000000..cf73de3
--- /dev/null
@@ -0,0 +1,25 @@
+#!/bin/bash
+
+# A bug in extension registration would leave unsupported older extension
+# revisions in pending list and get compatibility checked again for each rule
+# using them. With SELinux enabled, the resulting socket() call per rule leads
+# to significant slowdown (~50% performance in worst cases).
+
+set -e
+
+strace --version >/dev/null || { echo "skip for missing strace"; exit 0; }
+
+RULESET="$(
+       echo "*filter"
+       for ((i = 0; i < 100; i++)); do
+               echo "-A FORWARD -m conntrack --ctstate NEW"
+       done
+       echo "COMMIT"
+)"
+
+cmd="$XT_MULTI iptables-restore"
+socketcount=$(strace -esocket $cmd <<< "$RULESET" 2>&1 | wc -l)
+
+# unpatched iptables-restore would open 111 sockets,
+# patched only 12 but keep a certain margin for future changes
+[[ $socketcount -lt 20 ]]