]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe/oa: Remove WARN_ON's for unsupported configurations
authorAshutosh Dixit <ashutosh.dixit@intel.com>
Wed, 19 Jun 2024 22:56:17 +0000 (15:56 -0700)
committerAshutosh Dixit <ashutosh.dixit@intel.com>
Thu, 20 Jun 2024 16:18:20 +0000 (09:18 -0700)
The OA ioctl's already have drm_dbg's which are sufficient to tell the user
that OA is not supported on unsupported configurations (execlist mode and
platform gen < 12). Having additional WARN_ON's for these during driver
probe create unnecessary noise. Just remove these WARN_ON's.

Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240619225617.3465899-1-ashutosh.dixit@intel.com
drivers/gpu/drm/xe/xe_oa.c

index 36b2e89b78b6c08e30e6fdd38b9580962db8d393..eaa5fe5fd75b6535340d970acad8a1e3fc792e68 100644 (file)
@@ -2385,7 +2385,7 @@ int xe_oa_init(struct xe_device *xe)
        int ret;
 
        /* Support OA only with GuC submission and Gen12+ */
-       if (XE_WARN_ON(!xe_device_uc_enabled(xe)) || XE_WARN_ON(GRAPHICS_VER(xe) < 12))
+       if (!xe_device_uc_enabled(xe) || GRAPHICS_VER(xe) < 12)
                return 0;
 
        oa->xe = xe;