]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
extcon: Drop unneeded assignments
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 11 Apr 2023 11:48:24 +0000 (14:48 +0300)
committerChanwoo Choi <cw00.choi@samsung.com>
Mon, 29 May 2023 14:41:29 +0000 (23:41 +0900)
In one case the assignment is duplicative, in the other,
it's better to move it into the loop — the user of it.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon.c

index 76dc41e8f25098716224efb29f6b2a9da422519d..6f7a60d2ed9161b21625a5949c9a24868cf4de33 100644 (file)
@@ -245,7 +245,7 @@ static DEFINE_MUTEX(extcon_dev_list_lock);
 
 static int check_mutually_exclusive(struct extcon_dev *edev, u32 new_state)
 {
-       int i = 0;
+       int i;
 
        if (!edev->mutually_exclusive)
                return 0;
@@ -1246,7 +1246,7 @@ static int extcon_alloc_groups(struct extcon_dev *edev)
  */
 int extcon_dev_register(struct extcon_dev *edev)
 {
-       int ret, index = 0;
+       int ret, index;
 
        ret = create_extcon_class();
        if (ret < 0)
@@ -1255,7 +1255,7 @@ int extcon_dev_register(struct extcon_dev *edev)
        if (!edev || !edev->supported_cable)
                return -EINVAL;
 
-       for (; edev->supported_cable[index] != EXTCON_NONE; index++);
+       for (index = 0; edev->supported_cable[index] != EXTCON_NONE; index++);
 
        edev->max_supported = index;
        if (index > SUPPORTED_CABLE_MAX) {