]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
security: Drop virSecurity(DAC|SELinux)RestoreImageLabelSingle()
authorAndrea Bolognani <abologna@redhat.com>
Mon, 20 Nov 2023 18:17:02 +0000 (19:17 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Wed, 20 Mar 2024 17:37:55 +0000 (18:37 +0100)
Each one only has a single, trivial caller.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
src/security/security_dac.c
src/security/security_selinux.c

index 7421496fc9ea94bee42b4a5265fe2bc31caf825f..9c24a1c4a8c6e169fea2afdbb53903a4e19feea0 100644 (file)
@@ -972,10 +972,10 @@ virSecurityDACSetImageLabel(virSecurityManager *mgr,
 }
 
 static int
-virSecurityDACRestoreImageLabelSingle(virSecurityManager *mgr,
-                                      virDomainDef *def,
-                                      virStorageSource *src,
-                                      bool migrated)
+virSecurityDACRestoreImageLabelInt(virSecurityManager *mgr,
+                                   virDomainDef *def,
+                                   virStorageSource *src,
+                                   bool migrated)
 {
     virSecurityDACData *priv = virSecurityManagerGetPrivateData(mgr);
     virSecurityLabelDef *secdef;
@@ -1047,19 +1047,6 @@ virSecurityDACRestoreImageLabelSingle(virSecurityManager *mgr,
 }
 
 
-static int
-virSecurityDACRestoreImageLabelInt(virSecurityManager *mgr,
-                                   virDomainDef *def,
-                                   virStorageSource *src,
-                                   bool migrated)
-{
-    if (virSecurityDACRestoreImageLabelSingle(mgr, def, src, migrated) < 0)
-        return -1;
-
-    return 0;
-}
-
-
 static int
 virSecurityDACRestoreImageLabel(virSecurityManager *mgr,
                                 virDomainDef *def,
index ffad058d9a8be34f8a444c61486846f34ad955c6..d491435ae17694e7e4a25bc5e8bb2d6f11415b22 100644 (file)
@@ -1774,10 +1774,10 @@ virSecuritySELinuxRestoreTPMFileLabelInt(virSecurityManager *mgr,
 
 
 static int
-virSecuritySELinuxRestoreImageLabelSingle(virSecurityManager *mgr,
-                                          virDomainDef *def,
-                                          virStorageSource *src,
-                                          bool migrated)
+virSecuritySELinuxRestoreImageLabelInt(virSecurityManager *mgr,
+                                       virDomainDef *def,
+                                       virStorageSource *src,
+                                       bool migrated)
 {
     virSecurityLabelDef *seclabel;
     virSecurityDeviceLabelDef *disk_seclabel;
@@ -1863,19 +1863,6 @@ virSecuritySELinuxRestoreImageLabelSingle(virSecurityManager *mgr,
 }
 
 
-static int
-virSecuritySELinuxRestoreImageLabelInt(virSecurityManager *mgr,
-                                       virDomainDef *def,
-                                       virStorageSource *src,
-                                       bool migrated)
-{
-    if (virSecuritySELinuxRestoreImageLabelSingle(mgr, def, src, migrated) < 0)
-        return -1;
-
-    return 0;
-}
-
-
 static int
 virSecuritySELinuxRestoreImageLabel(virSecurityManager *mgr,
                                     virDomainDef *def,