android: Leak the private key reference on Jelly Bean to avoid a bug in the framework

A bug in the framework on Android Jelly Bean causes a SIGSEGV when the private
key object returned from KeyChain.getPrivateKey is garbage collected.
Leaking the global reference to that object prevents the garbage
collection and thereby the crash.

diff --git a/src/frontends/android/jni/libandroidbridge/backend/android_private_key.c b/src/frontends/android/jni/libandroidbridge/backend/android_private_key.c
index e8a78b5da37f5913bbc4d61c09badb64e3dfc7ba..3ed3d75a97852cd9c1e9ce11552f9822947c4a69 100644 (file)
--- a/src/frontends/android/jni/libandroidbridge/backend/android_private_key.c
+++ b/src/frontends/android/jni/libandroidbridge/backend/android_private_key.c
@@ -232,7 +232,16 @@ METHOD(private_key_t, destroy, void,
                JNIEnv *env;
 
                androidjni_attach_thread(&env);
-               (*env)->DeleteGlobalRef(env, this->key);
+               if (android_sdk_version >= ANDROID_JELLY_BEAN)
+               {       /* there is a bug in JB that causes a SIGSEGV if the key object is
+                        * garbage collected so we intentionally leak the reference to it */
+                       DBG1(DBG_LIB, "intentionally leaking private key reference due to "
+                                "a bug in the framework");
+               }
+               else
+               {
+                       (*env)->DeleteGlobalRef(env, this->key);
+               }
                (*env)->DeleteGlobalRef(env, this->signature_class);
                androidjni_detach_thread();
                this->pubkey->destroy(this->pubkey);