]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: allwinner: Drop non-removable from SoPine/LTS SD card
authorAndre Przywara <andre.przywara@arm.com>
Wed, 13 Jan 2021 15:26:26 +0000 (15:26 +0000)
committerMaxime Ripard <maxime@cerno.tech>
Thu, 14 Jan 2021 11:49:56 +0000 (12:49 +0100)
The SD card on the SoPine SoM module is somewhat concealed, so was
originally defined as "non-removable".
However there is a working card-detect pin (tested on two different
SoM versions), and in certain SoM base boards it might be actually
accessible at runtime.
Also the Pine64-LTS shares the SoPine base .dtsi, so inherited the
non-removable flag, even though the SD card slot is perfectly accessible
and usable there. (It turns out that just *my* board has a broken card
detect switch, so I originally thought CD wouldn't work on the LTS.)

Drop the "non-removable" flag to describe the SD card slot properly.

Fixes: c3904a269891 ("arm64: allwinner: a64: add DTSI file for SoPine SoM")
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20210113152630.28810-5-andre.przywara@arm.com
arch/arm64/boot/dts/allwinner/sun50i-a64-sopine.dtsi

index c48692b06e1fa70a6e3263bf2a584172b3866f5f..3402cec87035bbea4ee851482323d99b4191c94c 100644 (file)
@@ -32,7 +32,6 @@
        pinctrl-names = "default";
        pinctrl-0 = <&mmc0_pins>;
        vmmc-supply = <&reg_dcdc1>;
-       non-removable;
        disable-wp;
        bus-width = <4>;
        cd-gpios = <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */