]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
imapc: Fixed crash if imapc_host or imapc_password setting was missing.
authorTimo Sirainen <tss@iki.fi>
Sun, 27 Sep 2015 18:30:56 +0000 (21:30 +0300)
committerTimo Sirainen <tss@iki.fi>
Sun, 27 Sep 2015 18:30:56 +0000 (21:30 +0300)
Instead of giving a nice error message about it.
Found by Coverity.

src/lib-storage/index/imapc/imapc-list.c

index fb8a9a624f1c7679c04f971d172d482d725fd2bb..13e53cd6cffb31af8daec1935392a6a49b0c54f2 100644 (file)
@@ -87,11 +87,10 @@ static void imapc_list_deinit(struct mailbox_list *_list)
 {
        struct imapc_mailbox_list *list = (struct imapc_mailbox_list *)_list;
 
-       list->client->destroying = TRUE;
-
        /* make sure all pending commands are aborted before anything is
           deinitialized */
        if (list->client != NULL) {
+               list->client->destroying = TRUE;
                imapc_client_disconnect(list->client->client);
                imapc_storage_client_unref(&list->client);
        }