]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
nouveau/firmware: Add missing kfree() of nvkm_falcon_fw::boot
authorNam Cao <namcao@linutronix.de>
Mon, 17 Nov 2025 08:42:31 +0000 (08:42 +0000)
committerLyude Paul <lyude@redhat.com>
Mon, 17 Nov 2025 23:12:17 +0000 (18:12 -0500)
nvkm_falcon_fw::boot is allocated, but no one frees it. This causes a
kmemleak warning.

Make sure this data is deallocated.

Fixes: 2541626cfb79 ("drm/nouveau/acr: use common falcon HS FW code for ACR FWs")
Signed-off-by: Nam Cao <namcao@linutronix.de>
Cc: stable@vger.kernel.org
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patch.msgid.link/20251117084231.2910561-1-namcao@linutronix.de
drivers/gpu/drm/nouveau/nvkm/falcon/fw.c

index cac6d64ab67d1ded596f6690b5e0ce58239b2bab..4e8b3f1c7e25d26f2474a1f1130c3fc9c8fb292a 100644 (file)
@@ -159,6 +159,8 @@ nvkm_falcon_fw_dtor(struct nvkm_falcon_fw *fw)
        nvkm_memory_unref(&fw->inst);
        nvkm_falcon_fw_dtor_sigs(fw);
        nvkm_firmware_dtor(&fw->fw);
+       kfree(fw->boot);
+       fw->boot = NULL;
 }
 
 static const struct nvkm_firmware_func