]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dmaengine: sf-pdma: apply proper spinlock flags in sf_pdma_prep_dma_memcpy()
authorAustin Kim <austin.kim@lge.com>
Fri, 11 Jun 2021 06:53:36 +0000 (07:53 +0100)
committerVinod Koul <vkoul@kernel.org>
Wed, 16 Jun 2021 10:40:00 +0000 (16:10 +0530)
The second parameter of spinlock_irq[save/restore] function is flags,
which is the last input parameter of sf_pdma_prep_dma_memcpy().

So declare local variable 'iflags' to be used as the second parameter of
spinlock_irq[save/restore] function.

Signed-off-by: Austin Kim <austin.kim@lge.com>
Link: https://lore.kernel.org/r/20210611065336.GA1121@raspberrypi
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sf-pdma/sf-pdma.c

index c4c4e857576435455864049e5950e3c8164981f8..f12606aeff87c918ef2ec6b74f46fb05324c789d 100644 (file)
@@ -94,6 +94,7 @@ sf_pdma_prep_dma_memcpy(struct dma_chan *dchan,       dma_addr_t dest, dma_addr_t src,
 {
        struct sf_pdma_chan *chan = to_sf_pdma_chan(dchan);
        struct sf_pdma_desc *desc;
+       unsigned long iflags;
 
        if (chan && (!len || !dest || !src)) {
                dev_err(chan->pdma->dma_dev.dev,
@@ -109,10 +110,10 @@ sf_pdma_prep_dma_memcpy(struct dma_chan *dchan,   dma_addr_t dest, dma_addr_t src,
        desc->dirn = DMA_MEM_TO_MEM;
        desc->async_tx = vchan_tx_prep(&chan->vchan, &desc->vdesc, flags);
 
-       spin_lock_irqsave(&chan->vchan.lock, flags);
+       spin_lock_irqsave(&chan->vchan.lock, iflags);
        chan->desc = desc;
        sf_pdma_fill_desc(desc, dest, src, len);
-       spin_unlock_irqrestore(&chan->vchan.lock, flags);
+       spin_unlock_irqrestore(&chan->vchan.lock, iflags);
 
        return desc->async_tx;
 }