]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iommu/amd: Ensure GA log notifier callbacks finish running before module unload
authorSean Christopherson <seanjc@google.com>
Sat, 15 Mar 2025 03:10:48 +0000 (20:10 -0700)
committerJoerg Roedel <jroedel@suse.de>
Mon, 28 Apr 2025 11:40:20 +0000 (13:40 +0200)
Synchronize RCU when unregistering KVM's GA log notifier to ensure all
in-flight interrupt handlers complete before KVM-the module is unloaded.

Signed-off-by: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20250315031048.2374109-1-seanjc@google.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd/iommu.c

index be8761bbef0ffbd2755665421f9fcaceb7774c8d..15e3342648811a999689128d612b25c0774003ef 100644 (file)
@@ -982,6 +982,14 @@ int amd_iommu_register_ga_log_notifier(int (*notifier)(u32))
 {
        iommu_ga_log_notifier = notifier;
 
+       /*
+        * Ensure all in-flight IRQ handlers run to completion before returning
+        * to the caller, e.g. to ensure module code isn't unloaded while it's
+        * being executed in the IRQ handler.
+        */
+       if (!notifier)
+               synchronize_rcu();
+
        return 0;
 }
 EXPORT_SYMBOL(amd_iommu_register_ga_log_notifier);