]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/amdgpu/jpeg4: add additional ring reset error checking
authorAlex Deucher <alexander.deucher@amd.com>
Mon, 7 Jul 2025 15:00:24 +0000 (11:00 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 16 Jul 2025 20:09:25 +0000 (16:09 -0400)
Start and stop can fail, so add checks.

Fixes: 74894ffc7d0c ("drm/amdgpu: Add ring reset callback for JPEG4_0_0")
Reviewed-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Sathishkumar S <sathishkumar.sundararaju@amd.com>
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c

index 1d4edd77837d0104a480f65dc059428b64ab27b1..78fe1924f3cb7f2e2ff47732ff9b2ab00740b0a4 100644 (file)
@@ -730,8 +730,12 @@ static int jpeg_v4_0_ring_reset(struct amdgpu_ring *ring,
                return -EINVAL;
 
        drm_sched_wqueue_stop(&ring->sched);
-       jpeg_v4_0_stop(ring->adev);
-       jpeg_v4_0_start(ring->adev);
+       r = jpeg_v4_0_stop(ring->adev);
+       if (r)
+               return r;
+       r = jpeg_v4_0_start(ring->adev);
+       if (r)
+               return r;
        r = amdgpu_ring_test_helper(ring);
        if (r)
                return r;